Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks/cijenkinsio-agents-2): setup technical addons for taint and toleration + add autoscaler #67

Merged
merged 16 commits into from
Dec 20, 2024

Conversation

smerle33
Copy link
Contributor

@smerle33 smerle33 commented Dec 20, 2024

Ref: jenkins-infra/helpdesk#4319

adding the addons with taints and toleration
adding autoscaler with helm provider

@dduportal dduportal self-assigned this Dec 20, 2024
@dduportal
Copy link
Contributor

Added a few changes:

  • Removed the kube-proxy add-on configuration to avoid the error InvalidParameterException: ConfigurationValue provided in request is not supported: Json schema validation failed with error: [$.tolerations: is not defined in the schema and the schema does not allow additional properties]
  • Factorized the tolerations/taints and node labels to locals to avoid repetition and human error
  • Fixed the helm_release resource to:
    • Use the alias provider (otherwise it cannot find which kubernetes config to use as there are no default helm provider)
    • Use the namespace specified for the service account (otherwise the installation won't be able to authenticate properly from the default namespace). Need to create the namespace if not existing (setting up the associated attribute to true)
    • Pass tolerations and node selector labels to the templatized helm values
    • Make the templated YAML safer by using double quote on variable (to avoid accidental implicit castings to booleans or numbers)

Signed-off-by: Damien Duportal <[email protected]>
locals.tf Outdated Show resolved Hide resolved
@smerle33 smerle33 changed the title feat(eks/cijenkinsio-agents-2): add toleration and taint for our system/application nodepool…em/application nodepool feat(eks/cijenkinsio-agents-2): setup technical addons for taint and toleration + add autoscaler Dec 20, 2024
@smerle33 smerle33 marked this pull request as ready for review December 20, 2024 13:36
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plan: 5 to add, 1 to change, 1 to destroy.

@smerle33 smerle33 merged commit 780a2b4 into jenkins-infra:main Dec 20, 2024
3 checks passed
@smerle33 smerle33 deleted the nodepools branch December 20, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants